BIG PR VERS MAIN : Principalement connexion BACK au FRONT Profil #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajout de la fonctionnalité pour ajouter une bannière
Token stocké dans le context
Route admin sécurisé
Frontend : Page Admin protégée
ajout banniere fonctionnelle
finished Collection routing
ajout de la fonctionnalité d'achat d'avatar dans la boutique
updated banner
Squelette Page Admin
| setPlayers(res.data); | ||
| }); | ||
| }, []); | ||
| console.info(players); |
There was a problem hiding this comment.
Pas de console.info()
Comment on lines
16
to
18
| console.info(setPrimaryColor); | ||
| console.info(setSecondaryColor); | ||
| console.info(setTextColor); |
Comment on lines
4
to
9
| const handleScrollToTop = () => { | ||
| window.scrollTo({ | ||
| top: 0, | ||
| behavior: "smooth", | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Il y a une répétition de fou sur ce morceau de code, pourquoi de pas créer un service et de l'appeler où il se doit ?
Comment on lines
4
to
9
| const handleScrollToTop = () => { | ||
| window.scrollTo({ | ||
| top: 0, | ||
| behavior: "smooth", | ||
| }); | ||
| }; |
Comment on lines
4
to
9
| const handleScrollToTop = () => { | ||
| window.scrollTo({ | ||
| top: 0, | ||
| behavior: "smooth", | ||
| }); | ||
| }; |
fix pour merge vers main
GorskiAnthony
approved these changes
Feb 5, 2024
|
Woaw ! La rapidité ! Done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grande PR (la dernière normalement), qui concerne quasiment que le profil du joueur