Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile should build image from source #84

Open
i-ky opened this issue Mar 5, 2024 · 1 comment
Open

Dockerfile should build image from source #84

i-ky opened this issue Mar 5, 2024 · 1 comment

Comments

@i-ky
Copy link

i-ky commented Mar 5, 2024

Dockerfile which was added in #69 and #70 installs swagger-merger NPM package:

RUN npm install -g swagger-merger watch

It is probably the most efficient way to build a Docker image around swagger-merger, but it leaves a lot to be desired. For example, how would someone build a swagger-merger Docker image with the latest features from GitHub repo, from a branch, from a fork, with changes from someone's local working directory?

There should be a Dockerfile that allows building image from source code checkout instead of relying on NPM.

@dhyanio
Copy link

dhyanio commented Nov 29, 2024

Use yaml-merger https://github.com/dhyanio/yaml-merger fast and performant swagger-merger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants