device: return generic error from Ipc{Get,Set}Operation. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All atomic access must be aligned to 64 bits, even on 32-bit platforms. Go promises that the start of allocated structs is aligned to 64 bits. So, place the atomically-accessed things first in the struct so that they benefit from that alignment. As a side bonus, it cleanly separates fields that are accessed by atomic ops, and those that should be accessed under mu. Also adds a test that will fail consistently on 32-bit platforms if the struct ever changes again to violate the rules. This is likely not needed because unaligned access crashes reliably, but this will reliably fail even if tests accidentally pass due to lucky alignment. Signed-Off-By: David Anderson <danderson@tailscale.com>
Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>
The sticky socket code stays in the device package for now, as it reaches deeply into the peer list. This is the first step in an effort to split some code out of the very busy device package. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Based on types and config parser from wireguard-windows. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
Signed-off-by: Tyler Kropp <kropptyler@gmail.com>
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
This code is useful to other packages writing tests. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
bradfitz
reviewed
Apr 1, 2020
This makes uapi.go's public API conform to Go style in terms of error types. Signed-off-by: David Anderson <danderson@tailscale.com>
danderson
force-pushed
the
danderson/uapi-err-type
branch
from
65f1869
to
11705e6
Compare
|
LGTM |
crawshaw
approved these changes
Apr 2, 2020
|
Merged upstream. I can't close your PRs. |
|
This might have implications for wireguard-android, wireguard-windows, and wireguard-apple: https://github.com/WireGuard/wireguard-windows/blob/master/tunnel/service.go#L199-L204 https://github.com/WireGuard/wireguard-apple/blob/master/wireguard-go-bridge/api-ios.go#L107-L111 |
zx2c4-bot
force-pushed
the
master
branch
6 times, most recently
from
8a3c04a
to
28c4d04
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
6b5293b
to
6005c57
Compare
zx2c4-bot
force-pushed
the
master
branch
6 times, most recently
from
58beb0f
to
54dbe24
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
1ae3898
to
4e9e5da
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
eba36c5
to
ffb742d
Compare
zx2c4-bot
force-pushed
the
master
branch
5 times, most recently
from
89a9432
to
b9669b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes uapi.go's public API conform to Go style in terms
of error types.
Signed-off-by: David Anderson danderson@tailscale.com