Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two Handhake initiation releated race-conditions fixed #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Two Handhake initiation releated race-conditions fixed #48

wants to merge 2 commits into from

Conversation

drgkaleda
Copy link

  • Fix race-condition between data TX watchdog timer and handshakes retries timer
  • (at the same time) Fix and unify handshake attempts counter usage: now 0 means no HI in progress. Can use that timer to check if and HIs already sent.
  • Do not flood new handhake initiations, if HI is already scheduled by somebody else.

Antanas Gadeikis added 2 commits May 20, 2021 14:15
An attemt to fix handshakeAttempts atomic counter:
d164cb3 
0 means no HandshakeInitiation (HI) is in progress.
Positive number - how many HIs have been already send.
This patch also fixes race condition between HI retries and data sent watchdog timer(timersDataSent vs expiredRetransmitHandshake)

Signed-off-by: Antanas Gadeikis <antanas.gadeikis@nordsec.com>
Do not flood new HandshakeInitiations, if some is already in progress
425aa97 
Signed-off-by: Antanas Gadeikis <antanas.gadeikis@nordsec.com>
@drgkaleda
Copy link
Author

Initially those raceconditions were observed on Windows.
Also I was able to reproduce them on Linux.
Debug and testing was done on Linux.
Mac version was untested, but I think it should have the same problem.

@zx2c4-bot zx2c4-bot force-pushed the master branch 5 times, most recently from 89a9432 to b9669b7 Compare February 2, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drgkaleda