Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator id numbering #549

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

oxixes
Copy link
Contributor

@oxixes oxixes commented Jul 8, 2024

Proposed changes

The operator ID is represented as a string when it should not, which causes the IDs of new operators to just be old one plus a one, leading to IDs like "9711111111111". This PR fixes that issue.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

None

@coveralls
Copy link

coveralls commented Jul 8, 2024

Coverage Status

coverage: 88.222% (+0.01%) from 88.21%
when pulling 967b89b on oxixes:fix-operator-numbering
into 2a25766 on Wirecloud:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants