Transition to pyproject.toml
#43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move script to `src/sortgs` - add `__init__.py` - remove requirements.txt and setup.py
|
Thanks for this wonderful contrib! I'm happy to learn and incorporate better practices in Python. The current test scripts are failing due to the following: Can you update this PR by updating test.yml so that it can run? I believe that removing |
|
Fixed in #46 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! This is an interesting tool for my purposes, and I just wanted to contribute back a bit. Basically this PR makes the package conform to PEP 621, the modern Python packaging standard, i.e. instead of using
setup.py,setup.cfg,requirements.txtetc. all of the packaging-related info is now located inpyproject.toml.