Improve cache busting via Refresh button #6756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rankings this fixes an issue with character parses for awakened raids, which do not include the awakened ranks in the "All" partition that is selected by default
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/common/fetchWclApi.ts
Did you find this useful? React with a 👍 or 👎 |
ToppleTheNun
approved these changes
May 3, 2024
| } | ||
|
|
||
| const ZONES: Zone[] = [ | ||
| { | ||
| id: 31, | ||
| name: 'Vault of the Incarnates', | ||
| frozen: false, | ||
| partition: 4, |
There was a problem hiding this comment.
Back to partitions mattering! Woo!
emallson
added a commit
to emallson/WoWAnalyzer
that referenced
this pull request
May 6, 2024
* use `cache` param instead of query param to skip cache * support setting specific partitions for zones when loading character rankings this fixes an issue with character parses for awakened raids, which do not include the awakened ranks in the "All" partition that is selected by default * changelog entry
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the v2 server migration greatly improved the use of caching and cache-control headers on the server. This had the side-effect of revealing some issues with our cache-busting method. Specifically: if you bust the cache by setting a query param, the new response is stored under a new URL. But when you refresh the page the old response under the old URL is read.
This PR changes the cache-busting method to use the
cache-controlheader via thecacheparameter offetch. When set toreload, the behavior is:per MDN.
While I was working on this, I realized that we can't retrieve Awakened parses on the character parses page due to how the partitions are set up on WCL. I worked around it since we don't really support old seasons' logs anyway.
This requires this PR on the backend.