Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GLM to Git submodules #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented Apr 25, 2022

Removing the version suffix since that is implicitly specified by the git tag - making updating simpler

@autious
Copy link
Collaborator

autious commented Apr 27, 2022

I think for now I'm going to wait with merging work that adds submodules until we've removed the Auxiliary and Proprietary submodules, and instead set up the build system to explicitally download them through some other means. Reason being that i want the tutorial we wrote to stay true.

I suspect that submoduling like this also will break downloading and compiling via "Download as zip" workflow. Making our quick-setup video obsolete.

It's important for me to maintain the simplicity of getting things up and running for budding and completely green programmers who just want to get a taste of what it might be like to dig through some code.

@feliwir
Copy link
Contributor Author

feliwir commented Apr 27, 2022

It will break the "Download as zip" indeed and it makes sense till the private/proprietary submodules are removed.

Overall git submodules will increase the "complexity" of how to get things running, but i think there needs to be a tradeoff between being friendly to newcomers & being in a good shape for programmers who want to do more than just "compiling" the binaries.

As discussed in #15 there are many benefits of having an easy upgrade path for thirdparty dependencies and not having any partially customized external libraries.

@Conan-Kudo Conan-Kudo added the blocked This issue or pull request cannot be resolved right now label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request cannot be resolved right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants