-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: MCST Elbrus initial port #37
base: main
Are you sure you want to change the base?
Conversation
Overall, it just smells bad when code have |
I'm currently in the process of replacing the insource dependencies - so the compilation should work with upstream versions of the libraries. See #15 |
@feliwir does your upstreaming work collide with this pull request, or do you recommend that we pull this in? @a1batross, i agree on the #include <f.cpp> thing. |
This is not necessarily true. Linking time etc can dominate on some platforms. One of the reasons why "unity builds" are a thing. |
@autious If something inside those libraries does not compile on any platform it should be fixed upstream and we can then upgrade to the version containing the fix. E.g. for ZStd do a PR for that file inside the official repository: https://github.com/facebook/zstd/blob/v1.5.0/lib/common/compiler.h#L154 |
Needed some changes in crnlib and zstd.
Probably upgrading to upstream zstd or using a system provided library would be better