Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove redundant comment #2282

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 4, 2023

Follow up on #2187 which removed the need to reset the minimum_wp_version property in test case files to a specific WP version, in favour of allowing a reset to "unset".

This means the version number in the WP/AlternativeFunctionsUnitTest.inc test case file doesn't need to be updated anymore when the default value of the minimum_wp_version changes, so this comment is now just confusing.

Follow up on 2187 which removed the need to reset the `minimum_wp_version` property in test case files to a specific WP version, in favour of allowing a reset to "unset".

This means the version number in the `WP/AlternativeFunctionsUnitTest.inc` test case file doesn't need to be updated anymore when the default value of the `minimum_wp_version` changes, so this comment is now just confusing.
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaryJones GaryJones merged commit 7f54dd0 into develop Jul 4, 2023
35 checks passed
@GaryJones GaryJones deleted the feature/docs-remove-comment branch July 4, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants