[RNMobile] Enable embed block (#33452)

* Remove embed thumbnail preview * Enable embed block
WordPress · Jul 20, 2021 · 94ab1a6 · 94ab1a6
1 parent 3b85572
commit 94ab1a6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 43 deletions.
diff --git a/packages/block-library/src/embed/edit.native.js b/packages/block-library/src/embed/edit.native.js
@@ -28,12 +28,7 @@ import { View } from '@wordpress/primitives';
 
 const EmbedEdit = ( props ) => {
 	const {
-		attributes: {
-			providerNameSlug,
-			previewable,
-			responsive,
-			url: attributesUrl,
-		},
+		attributes: { providerNameSlug, responsive, url: attributesUrl },
 		attributes,
 		isSelected,
 		onReplace,
@@ -191,8 +186,6 @@ const EmbedEdit = ( props ) => {
 							insertBlocksAfter={ insertBlocksAfter }
 							isSelected={ isSelected }
 							label={ title }
-							preview={ preview }
-							previewable={ previewable }
 							url={ url }
 						/>
 					</View>

diff --git a/packages/block-library/src/embed/embed-preview.native.js b/packages/block-library/src/embed/embed-preview.native.js
@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-import { TouchableWithoutFeedback, Image } from 'react-native';
+import { TouchableWithoutFeedback } from 'react-native';
 import { isEmpty } from 'lodash';
 
 /**
@@ -17,7 +17,6 @@ import { useState } from '@wordpress/element';
  * Internal dependencies
  */
 import EmbedNoPreview from './embed-no-preview';
-import styles from './styles.scss';
 
 const EmbedPreview = ( {
 	clientId,
@@ -27,8 +26,6 @@ const EmbedPreview = ( {
 	label,
 	onBlur,
 	onFocus,
-	preview,
-	previewable,
 } ) => {
 	const [ isCaptionSelected, setIsCaptionSelected ] = useState( false );
 
@@ -56,39 +53,19 @@ const EmbedPreview = ( {
 		}
 	}
 
-	const cannotShowThumbnail =
-		! previewable ||
-		! preview ||
-		! preview.thumbnail_url?.length ||
-		! preview.height ||
-		! preview.width;
-
 	return (
 		<TouchableWithoutFeedback
 			accessible={ ! isSelected }
 			onPress={ onEmbedPreviewPress }
 			disabled={ ! isSelected }
 		>
 			<View>
-				{ cannotShowThumbnail ? (
-					<EmbedNoPreview
-						label={ label }
-						icon={ icon }
-						isSelected={ isSelected }
-						onPress={ () => setIsCaptionSelected( false ) }
-					/>
-				) : (
-					<Image
-						style={ [
-							styles[ 'embed-preview__image' ],
-							{ aspectRatio: preview.width / preview.height },
-						] }
-						source={ {
-							uri: preview.thumbnail_url,
-						} }
-						resizeMode="cover"
-					/>
-				) }
+				<EmbedNoPreview
+					label={ label }
+					icon={ icon }
+					isSelected={ isSelected }
+					onPress={ () => setIsCaptionSelected( false ) }
+				/>
 				<BlockCaption
 					accessibilityLabelCreator={ accessibilityLabelCreator }
 					accessible

diff --git a/packages/block-library/src/embed/styles.native.scss b/packages/block-library/src/embed/styles.native.scss
@@ -84,10 +84,6 @@
 	background-color: $background-dark-secondary;
 }
 
-.embed-preview__image {
-	flex: 1 1 auto;
-}
-
 .embed-no-preview__container {
 	flex-direction: column;
 	align-items: center;

diff --git a/packages/block-library/src/index.native.js b/packages/block-library/src/index.native.js
@@ -266,7 +266,7 @@ export const registerCoreBlocks = () => {
 		audio,
 		reusableBlock,
 		search,
-		devOnly( embed ),
+		embed,
 	].forEach( registerBlock );
 
 	registerBlockVariations( socialLink );