Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a theme icon for the theme templates #68142

Open
juanfra opened this issue Dec 19, 2024 · 9 comments
Open

Consider using a theme icon for the theme templates #68142

juanfra opened this issue Dec 19, 2024 · 9 comments
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@juanfra
Copy link
Member

juanfra commented Dec 19, 2024

What problem does this address?

There are different icons used to represent template categories—user and plugin templates each have their own. However, theme templates don’t have a unique icon. It also feels a bit redundant that the “All Templates” icon is the same as the one for theme templates.

Image

What is your proposed solution?

It would feel more intuitive if the theme category had its own unique icon. While we already have an icon for plugins in the design system, there doesn’t seem to be one specifically for themes. One option could be to create a new icon for this purpose. Alternatively, we could use an existing icon from the system that better represents themes, like brush.

Pinging @WordPress/gutenberg-design

@juanfra juanfra added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Dec 19, 2024
@jasmussen
Copy link
Contributor

That seems valid. It needs a good icon design, one that feels conceptually related to the current icon. We have sidebar, footer, header versions of the "layout" icon already, that feel connected. What's a way to create a remix of the layout icon that's just for the active theme? Maybe a solid version rather than outline version?

@jameskoster
Copy link
Contributor

Yeah I don't think we were able to settle on an icon in the current set that represents 'theme', which is why the layout icon was reused.

Conceptually themes are a bundle of design assets; templates, styles, fonts, graphics, etc. Maybe something that plays on that?

Image

Or perhaps something more standard like a paint brush, echoing to the icon we find in wp-admin.

Image

@juanfra
Copy link
Member Author

juanfra commented Dec 19, 2024

Thanks so much for looking into this!

I really like both directions. Personally, I feel the paintbrush icon could create more cohesion with what WordPress users are already familiar with, making it especially helpful for those transitioning to the site editor.

@jasmussen
Copy link
Contributor

Of the two, I'd choose the masonry over the paintbrush. We already have a paintbrush in the verse icon, which leverages solids, suddenly introducing the outline style for painting accessories exits that metaphor a bit. That's not to say it's not a nice design, that was quite a good brush though.

@richtabor
Copy link
Member

Are those icons helpful on the grid there anyhow?

@fcoveram
Copy link
Contributor

I like the brush. It is consistent with the concept. The "Appearance" action in Admin and even the Theme team. I envision the masonry one for a new grid view, if the CSS inclusion keeps improving.

@jasmussen
Copy link
Contributor

It's really a well designed brush. My hesitancy is that it feels like a different visual language than these similar utensils we have:

Image
Image

@juanfra
Copy link
Member Author

juanfra commented Jan 9, 2025

It’s a bit tricky because the design language of these icons (verse and edit) might feel out of place in the sidebar, where the other icons have more of an outlined look.

While we do have the brush icon as an option, it feels slightly disconnected from the rest in my opinion.

brush-icon.mp4

@richtabor
Copy link
Member

I actually lean towards no icons here. If they're not adding communicative value, I question if they're needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants