Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: Vertical spacing of placeholder elements is broken in IE11. #8607

Closed
kjellr opened this issue Aug 6, 2018 · 5 comments
Closed

IE11: Vertical spacing of placeholder elements is broken in IE11. #8607

kjellr opened this issue Aug 6, 2018 · 5 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 6, 2018

Describe the bug

The content inside of placeholders is meant to be centered vertically. In most browsers, it is. For example:

screen shot 2018-08-06 at 12 14 19 pm

In IE11 however, that spacing is broken, and all content is aligned to the top of the container:

screen shot 2018-08-06 at 12 09 18 pm

screen shot 2018-08-06 at 12 09 37 pm

screen shot 2018-08-06 at 12 09 56 pm

screen shot 2018-08-06 at 12 10 19 pm

screen shot 2018-08-06 at 12 11 47 pm

To Reproduce

  1. Use IE11
  2. Add a block that uses a placeholder (The Image block for example)
  3. Observe the alignment of the items inside the light gray container.

Tested in:
Windows 7, IE 11.0.9600.17420
Gutenberg 3.4
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks Browser Issues Issues or PRs that are related to browser specific problems labels Aug 6, 2018
@webmandesign
Copy link
Contributor

This is actually related to #5791

Fix could be the same.

@kjellr kjellr mentioned this issue Nov 21, 2018
Merged
4 tasks
@aduth
Copy link
Member

aduth commented May 31, 2019

Related: The text does not wrap as expected and exceeds boundaries of the placeholder.

image

@talldan
Copy link
Contributor

talldan commented Apr 22, 2020

This still seems to be a little bit of an issue, though not quite as pronounced as before:
Screenshot 2020-04-22 at 4 00 56 pm

@talldan talldan added [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Apr 22, 2020
@paaljoachim
Copy link
Contributor

What needs to be done here?

@youknowriad
Copy link
Contributor

IE11 support is being dropped, context:

I'm closing this issue as it's not something we'll be investing in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser Issues Issues or PRs that are related to browser specific problems CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@youknowriad @talldan @kjellr @aduth @webmandesign @paaljoachim