-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated changelog - use nested headings for feature groups instead of indenting lists #34040
Merged
getdave
merged 1 commit into
trunk
from
update/automated-changelog-prefer-headings-over-indentation
Aug 12, 2021
Merged
Automated changelog - use nested headings for feature groups instead of indenting lists #34040
getdave
merged 1 commit into
trunk
from
update/automated-changelog-prefer-headings-over-indentation
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
@priethor I think you were keen on this change. When you have a moment let me know if it works for you. |
7 tasks
priethor
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
getdave
deleted the
update/automated-changelog-prefer-headings-over-indentation
branch
August 12, 2021 15:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #33719 it was decided that we should prefer nested heading levels over indenting lists for feature groupings.
This PR does that. Here's an example:
Notice how the feature groups (
Block Editor
,Widgets Editor
...etc) are all headings now and not lists.How has this been tested?
Run
npm run changelog -- --milestone="Gutenberg 11.2" --token=YOUR_GITHUB_PERSONAL_ACCESS_TOKEN
.Check the output uses nested headings not nested lists for feature groups.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.js
files for terms that need renaming or removal).