-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix horizontal overflow for selects with long names in sidebar #3786
Fix horizontal overflow for selects with long names in sidebar #3786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks great, especially after the last change that makes sure the label does not shrink at smaller widths.
b41ec3c
to
aab9dcc
Compare
label { | ||
margin-right: 10px; | ||
flex-shrink: 0; | ||
max-width: 75%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this have been possible to achieve with white-space: nowrap
?
https://developer.mozilla.org/en-US/docs/Web/CSS/white-space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For short label like this one, yes, but we wouldn't want to prevent wrapping for very long labels – with this solution, the label will wrap only when it starts to fill more than the max-width of 75%.
Noting that the At the very leaat checkboxes and radio buttons should be excluded, however |
Description
Fix for #3518.
The select element was not responding to Flexbox appropriately in Webkit browsers.
How Has This Been Tested?
Device: MacBook Pro 2015
Browsers: Chrome 62.0.3202.94, Safari 11.0.1, FireFox 57.0.1
Screenshots (jpeg or gifs if applicable):
Types of changes
Adding a
min-width: 0;
to select elements solves this issue.Checklist: