DependencyExtractionWebpackPlugin: Use module for @wordpress/interactivity #57602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
sirreal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use an explicit
moduleexternal type by default for the@wordpress/interactivityexternal module.Why?
In #57577, we switched the default external type from
module(externals are always hoisted to static imports) toimport(externals are always dynamicimport()s).That's likely desirable for most external modules, but
@wordpress/interactivityhas some known issues where it may not behave as expected if it's not initialized beforeDOMContentLoaded(#56986).By declaring an explicit
moduleexternal type for@wordpress/interactivity, webpack will always hoist this import to a static import, preventing issues with dynamic imports of the package.Testing Instructions for Keyboard
Check the snapshots.