RTLCSS Fix

[SmushyTaco]

This fixes #68364 to allow for the proper use of control directives.

What?

This PR stops the moving of comments and removal of comments from breaking RTLCSS control directives.

Why?

RTLCSS control directives use comments and if those comments are removed or moved, this will cause this to not function properly. See #68364 for more information.

How?

The issue is addressed by removing all comments only after RTLCSS control directives are processed. This is done by processing cssnano changes through it's proper webpack plugin.

Testing Instructions

Build this SCSS code:

.wp-block-create-block-my-block {
  /*!tedgfdfg*/
  /*!rtl:ignore*/
  text-align: left;
  /*!rtl:remove*/
  background: #CCC;
}

RTLCSS control directives will be correctly applied.

Testing Instructions for Keyboard

Not applicable.

Screenshots or screencast

Not applicable.

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
• Labels found: First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
• Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SmushyTaco <smushytaco@git.wordpress.org>
Co-authored-by: shvlv <shvv@git.wordpress.org>
Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SmushyTaco! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[SmushyTaco]

@gziolo I'm unsure as to why so many of these tests are failing since the changes I've made are minimal. Maybe you can look into it?

[shvlv]

Hi @SmushyTaco, it seems like you deleted package-lock.json or run npm update. It introduces unintentional changes. You could try to follow the suggestion https://tkdodo.eu/blog/solving-conflicts-in-package-lock-json, i.e., edit package.json and run npm install after that. If you need to rebase on trunk, you can resolve package.json conflicts, accept the theirs version of package-lock.json, and run npm install --package-lock-only.

[SmushyTaco]

I went ahead and added .idea to the .gitignore so I don't have to keep manually deleting files that are generated by WebStorm, I hope that isn't a problem.

I also added TODO messages for code that needs updating, simplified some REGEX, removed a redundant initializer, and fixed the syntax of a JSDoc.

[SmushyTaco]

@shvlv @gziolo all tests have passed! This PR is now ready to be merged!

[SmushyTaco]

@shvlv the .gitignore has been reverted and all tests have passed, this is ready to merge!

[SmushyTaco]

I don't have permission to add a label, so if you could do it for me that would be greatly appreciated.