Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social links block: Add Clear button for color option #68564

Merged

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Jan 9, 2025

What?

Add a clear button just like the other color controls.
Similer #63580

Why?

Add a clear button for consistency

How?

Added clearable: true

Testing Instructions

  1. Open a post or page.
  2. Insert a Social links block block.
  3. You can see that a clear button has been added to the Icon Color and Icon Background.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before1 after1
before2 after2
before3 after3

Copy link

github-actions bot commented Jan 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement. labels Jan 10, 2025
@carolinan
Copy link
Contributor

Hi @shimotmk is there an open issue related to this change?

@shimotmk
Copy link
Contributor Author

@carolinan
Thank you. 👍
There are no related issues
I found the problem and submitted a PR.

@carolinan carolinan merged commit 3a0fb96 into WordPress:trunk Jan 10, 2025
71 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 10, 2025
@Mamaduka
Copy link
Member

Thanks, @carolinan! I was about to merge this and then had to hop on a call 🙇

@shimotmk
Copy link
Contributor Author

Thanks for the review!

@shimotmk shimotmk deleted the fix/add-clear-button-to-social-links branch January 10, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants