Only show audio message when track ID matches active

[Anuj012004]

Fixes

Fixes #2202 by @obulat

Description

An audio-related error is observed across all audio cells in the content view. Specifically, all cells incorrectly display an error message regardless of their state. This occurs because the application does not validate whether the audio.id matches the activeMediaStore.id when setting the message. As a result, messages intended for the active audio track are incorrectly shown for all audio tracks.

Testing Instructions

A reliable way to test this behavior is to find .oga audio files in Safari.

1. Run the app locally and go to http://localhost:8443/search/audio?q=cat&extension=oga
2. Click on Play: you should see the error message only on the active track.

Compare with the same in production: you see that the error message is displayed on every track.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[dhruvkb]

@obulat's comment #2202 (comment), although correct in terms of the changes, was a bit out of date. We can access t directly as it has been defined in line 70. Also there is no longer a need to use .toString().

Suggested change

	? i18n.t(`audioTrack.messages.${activeMediaStore.message}`).toString()
	? t(`audioTrack.messages.${activeMediaStore.message}`)

In fact, using i18n introduces an error because that's an undefined variable.

Error: frontend types: src/components/VAudioTrack/VAudioTrack.vue(301,7): error TS2304: Cannot find name 'i18n'.

[Anuj012004]

Hey @dhruvkb,

I've updated the PR based on your suggestions:

1.Removed .toString() as it's no longer needed.
2.Using t directly since it's defined on line 70.
3.Fixed whitespace issues.

Please review and let me know if any other changes are needed. Thanks for the helpful feedback!

[Anuj012004]

Hey @dhruvkb,

One check failed on my PR. Could you please take a look to help identify what needs to be fixed?
Thanks!

[dhruvkb]

@Anuj012004 thanks for incorporating the feedback from the PR review. The changes in your PR are correct, and you might have noticed that the previously failing Lint check has passed. However the PR is failing the unit tests defined in the file frontend/test/unit/specs/components/AudioTrack/v-audio-track.spec.js. This means that the tests in that file have to be updated.

Now you would need to make changes to that file to rectify any incorrect test conditions, and run the tests locally with just frontend/run test:unit. Feel free to ask us if you need any help or assistance.

[Anuj012004]

Hey @dhruvkb,
Please help me to fix the issue. I added test cases and due to my system's limitations I am unable to debug the failing tests effectively.

[openverse-bot]

Based on the contributor urgency of this PR, the following reviewers are being gently reminded to review this PR:

@obulat
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 4 day(s) ago. PRs labelled with contributor urgency are expected to be reviewed within 3 weekday(s)².

@Anuj012004, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

[obulat]

Thank you for your contribution, @Anuj012004 !

I fixed the unit tests, and am going to merge this PR.

The requested changes have been added.