Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the requirements at PHP 5.6 and WP 4.6 until we have a practical reason #641

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Keep the requirements at PHP 5.6 and WP 4.6 until we have a practical reason #641

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b280472
Keep the requirements at PHP 5.6 and WP 4.6 until we have a practical…
kasparsd Sep 19, 2024
1b9dcde
Add an upgrade notice
kasparsd Sep 19, 2024
66f827c
Link to the source of this information
kasparsd Sep 19, 2024
085f375
Add unit test run for PHP 5.6 + WP 4.6
dd32 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"minimum-stability": "dev",
"prefer-stable" : true,
"require": {
"php": ">=7.2.24|^8"
"php": ">=5.6"
},
"require-dev": {
"automattic/vipwpcs": "^3.0",
Expand All @@ -37,7 +37,7 @@
},
"scripts": {
"lint": "phpcs",
"lint-compat": "phpcs -p --standard=PHPCompatibilityWP --runtime-set testVersion 7.2- --extensions=php --ignore='tests/,dist/,includes/Yubico/,vendor/,node_modules/' .",
"lint-compat": "phpcs -p --standard=PHPCompatibilityWP --runtime-set testVersion 5.6- --extensions=php --ignore='tests/,dist/,includes/Yubico/,vendor/,node_modules/' .",
"lint-phpstan": "phpstan analyse --verbose --memory-limit=1G",
"test": "vendor/bin/phpunit",
"test:watch": [
Expand Down
11 changes: 11 additions & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ Here is a list of action and filter hooks provided by the plugin:
- `two_factor_user_authenticated` action which receives the logged in `WP_User` object as the first argument for determining the logged in user right after the authentication workflow.
- `two_factor_token_ttl` filter overrides the time interval in seconds that an email token is considered after generation. Accepts the time in seconds as the first argument and the ID of the `WP_User` object being authenticated.

= PHP and WordPress Version Support =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dd32, @jeffpaul What do you think of this policy?


Starting from version 1.0.0 of this plugin, it will maintain compatibility with WordPress core versions that are up to one year old, as well as <a href="https://make.wordpress.org/core/handbook/references/php-compatibility-and-wordpress-versions/">the minimum PHP version supported by those WordPress versions</a>.

== Frequently Asked Questions ==

= How can I send feedback or get help with a bug? =
Expand All @@ -47,6 +51,13 @@ To report a security issue, please visit the [WordPress HackerOne](https://hacke
2. U2F Security Keys section under User Profile.
3. Email Code Authentication during WordPress Login.

== Upgrade Notice ==

<!-- Keep this in sync with the next version up until 1.0.0. -->
= 0.10.0 =

From version 1.0.0, this plugin will support WordPress versions up to one year old and the minimum PHP version they require.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the built-in WP plugin upgrade notice UI to inform users about the upcoming change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority of users will never see such a message, whether it be in the Changelog, Description, or Upgrade Notice (which is seen only on the Dashboard -> Updates page)


== Changelog ==

See the [release history](https://github.com/wordpress/two-factor/releases).
4 changes: 2 additions & 2 deletions two-factor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
* Plugin URI: https://wordpress.org/plugins/two-factor/
* Description: Enable Two-Factor Authentication using time-based one-time passwords, Universal 2nd Factor (FIDO U2F, YubiKey), email, and backup verification codes.
* Version: 0.9.1
* Requires at least: 6.3
* Requires PHP: 7.2
* Requires at least: 4.6
* Requires PHP: 5.6
* Author: WordPress.org Contributors
* Author URI: https://github.com/wordpress/two-factor/graphs/contributors
* License: GPL-2.0-or-later
Expand Down
Loading