Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Convert to Compound Component #962

Closed
jpante opened this issue Feb 8, 2021 · 1 comment · Fixed by #1091
Closed

Modal: Convert to Compound Component #962

jpante opened this issue Feb 8, 2021 · 1 comment · Fixed by #1091
Assignees
@NicholasBoll
Labels
5.x enhancement New feature or request
Milestone
5.0.0

Comments

@jpante
Copy link
Member

jpante commented Feb 8, 2021

🚀 Feature Proposal

Evolve modal to the compound component pattern (CCP).

Motivation

Modal is one of the most requested components for variants, evolving the modal to support the CCP will allow for increased flexibility and usability of the CK Modal component

Related Issues

#905 feat(modal): Support scrolling entire modal
#756 Modal - allow aria-labeldBy prop to be passed
#786 Modal - full width and full height support
#681 More Modal variants
#790 Modal: Support scrolling entire modal / overlay for overflowing content.
@jpante jpante added enhancement New feature or request p:1 5.x labels Feb 8, 2021
@jpante jpante added this to the 5.0.0 milestone May 24, 2021
@anicholls anicholls changed the title Convert Modal to Compound Component Modal: Convert to Compound Component May 24, 2021
@jpante jpante mentioned this issue May 24, 2021
Closed
@NicholasBoll NicholasBoll mentioned this issue Jun 7, 2021
Merged
@NicholasBoll NicholasBoll linked a pull request Jun 7, 2021 that will close this issue
Refactor/modal compound component #1091
Merged
@NicholasBoll
Copy link
Member

Closed by #1091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicholasBoll NicholasBoll

Labels
5.x enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Refactor/modal compound component NicholasBoll/canvas-kit
3 participants
@NicholasBoll @jpante @jaclynjessup