Skip to content

Commit

Permalink
Core: Fixed OnLootReady handling with 3rd party loot addons
Browse files Browse the repository at this point in the history
There have been reports of the latest loot handling change causing attempts to not be registered. After some investigation, it turns out that certain "fast loot" addons exist that basically spam-loot via LootItem API on LOOT_READY. Examples of these are AutoLootPlusPlus and ElvUI_WindTools/FastLoot

Both of them cause the LOOT_OPENED event to not be triggered, which means Rarity won't trigger OnLootReady either - or at least not reliably. Since we used only LOOT_READY before, there's probably no reason to rely on LOOT_OPENED as long as the detection is working fine (and spam-opening containers doesn't fail).

If this causes problems for regular users it should be rolled back.
  • Loading branch information
rdw-software committed Aug 25, 2023
1 parent fe119a0 commit cbbe367
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Core/EventHandlers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function EventHandlers:Register()

self:UnregisterAllEvents()
self:RegisterBucketEvent("BAG_UPDATE", 0.5, "OnBagUpdate")
self:RegisterBucketEvent({ "LOOT_READY", "LOOT_OPENED", "LOOT_READY" }, 0.5, "OnLootReady")
self:RegisterBucketEvent("LOOT_READY", 0.5, "OnLootReady")
self:RegisterEvent("CURRENCY_DISPLAY_UPDATE", "OnCurrencyUpdate")
self:RegisterEvent("RESEARCH_ARTIFACT_COMPLETE", "OnResearchArtifactComplete")
self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED", "OnCombat") -- Used to detect boss kills that we didn't solo
Expand Down

0 comments on commit cbbe367

Please sign in to comment.