Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primal Storm events aren't detected (attempts for the relevant pets are always added) #655

Closed
rdw-software opened this issue Sep 24, 2023 · 5 comments · Fixed by #720
Closed

Comments

@rdw-software
Copy link
Member

rdw-software commented Sep 24, 2023

Rarity currently adds attempt for these pets regardless of whether or not a Primal Storm event is active in the area.

This was clearly an oversight on my part, though it wasn't reported as a problem so far. Hopefully no one spent too much time killing things that couldn't actually drop the items... oh well. Depending on how difficult it would be to detect Primal Storms, it might not be worth spending too much time on fixing this if no one has complained yet...?


Follow-up to #516

@rdw-software
Copy link
Member Author

@cyriun
Copy link
Contributor

cyriun commented Sep 24, 2023

there is a buff enemies gain called "Elementally Imbued"

@rdw-software
Copy link
Member Author

rdw-software commented Sep 24, 2023

Thanks! Then it should be simple to add, though I'm not sure which of these needs to be tracked:

Can probably scan for these via UNIT_AURA event, or use the C_UnitAuras.GetAuraDataBySlot API, with UnitAuraSlots?

@cyriun
Copy link
Contributor

cyriun commented Sep 24, 2023

from looking around it looks like 90% of the mobs have the buff, im assuming the mobs that are already in those areas when theres no elemental storm gain the buff and mobs spawn when the elemental storm is active dont have the buff. not sure on this so will have too check after the storm goes

@cyriun
Copy link
Contributor

cyriun commented Oct 10, 2023

check #659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment