Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The detection for Dreamseed Cache mounts is broken #690

Closed
rdw-software opened this issue Nov 24, 2023 · 1 comment · Fixed by #691
Closed

The detection for Dreamseed Cache mounts is broken #690

rdw-software opened this issue Nov 24, 2023 · 1 comment · Fixed by #691
Labels
Complexity: Trivial Priority: High Scope: Core Status: Resolved Type: Bug

Comments

@rdw-software
Copy link
Member

rdw-software commented Nov 24, 2023 •
edited
Loading

Source: WowAce

Based on the log provided, one of the items was set as tracked but no attempts were detected.
@rdw-software
Copy link
Member Author

This loop is incorrect: It's passing index as the item name, which can never work. Somehow I missed it when reviewing the PR.

@rdw-software rdw-software linked a pull request Nov 25, 2023 that will close this issue
Fix the detection for Dreamseed Cache mounts #691
Merged
@rdw-software rdw-software changed the title Investigate detection for Dreamseed Cache mounts (may not be working reliably?) The detection for Dreamseed Cache mounts is broken Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Trivial Priority: High Scope: Core Status: Resolved Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the detection for Dreamseed Cache mounts WowRarity/Rarity
1 participant
@rdw-software