Set up automated testing for the serialization module #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
import-string-tests
branch
from
ab6c8e1
to
3a9458a
Compare
Some boilerplate is required to get any tests running. Improve later... This replaces the original LuaUnit-based approach, which is clearly a dead end.
Very incomplete, but it's probably still better than nothing at all.
No idea why I left it in there. Good riddance, I guess?
These are added by the CurseForge packager before creating a release archive, but that doesn't allow testing them locally or pinning their versions. It might be worth embedding some of the smaller dependencies that rarely ever change just to make things more reproducible. Example: LibStub is tiny and hasn't been updated in 7 years.
rdw-software
force-pushed
the
import-string-tests
branch
from
8d0eedc
to
6bd4a7c
Compare
rdw-software
force-pushed
the
import-string-tests
branch
from
6bd4a7c
to
0de158d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the few modules that can easily be tested (compared to some of the other code). Originally, I was planning to use LuaUnit for this and I also tried WowUnit, but both solutions don't seem appropriate. We'll see if this approach is better, got to start somewhere though. If it works well, then the validation logic could be migrated next. Definitely beats having no tests at all...
As a bonus, it's now easier to decode and test import strings (e.g., those posted for DF items on wowhead) - especially offline.