Add Everlasting Horn of Lavaswimming (toy) to the database

[cyriun]

adding Everlasting Horn of Lavaswimming toy. Too get a more accurate tracking on this toy you would have to track the event completion but for now its tracked by killing the mob "Inferna the Bound" at the end of the event "Siege on Dragonbane Keep".

[cyriun]

been a few months since i've contributed on here so let me know if im missing anything, thanks

[rdw-software]

Thanks! There's probably a better way to track this that also works if you don't actually loot the boss. The comments on wowhead say that the item can be obtained by just AFKing, which to me indicates that it's probably tied to the scenario itself.

We can still use this and improve the detection later, though, if anyone wants to check the event ingame (using /etrace).

[cyriun]

yes i would say also tracking the container is better than the boss because then you still get an attempt from afking the event but i had just copy pasted the ids from an import string haha

[rdw-software]

Did you still want to implement the scenario detection I outlined in #514, or should I just push my version?
I really don't want to discourage you from experimenting and learning, so feel free to give it a try (it's just one extra function).

If you want to take a look, here's what I did: wip-pr-599 (Ideally, use only for cross-referencing)

[cyriun]

yeah i could take a look and ive been trying to but i think the event only happens ever 2 hours or so and i keep missing it due to having other stuff to do.

[rdw-software]

No problem, completely up to you. Just let me know when/if we can merge this (or my version, whichever you prefer).

[cyriun]

is line 60 relevant for debugging or the tracking altogether?

[rdw-software]

is line 60 relevant for debugging or the tracking altogether?

What line is that? If it's RegisterEvent, then yes: https://wowpedia.fandom.com/wiki/API_Frame_RegisterEvent

[cyriun]

ok yes so i think thats where mine went wrong, i seen "self:RegisterEvent("QUEST_TURNED_IN", "OnQuestTurnedIn")" and used that but i think it should've still worked so im not sure

[cyriun]

ok nvm the onquestturnedin function does work, i must have done something else wrong last time i tried it

[cyriun]

No problem, completely up to you. Just let me know when/if we can merge this (or my version, whichever you prefer).

whichever one you think works better, they probably are pretty much the same though, from my understanding

[rdw-software]

You need to modify the existing OnQuestTurnedIn handler if you want to use that event :)

[rdw-software]

Merging with some cosmetic changes (streamlined commit history and removed an outdated comment). Thanks!