Fix the tooltip for faction specific container items #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic is mostly trivial, but it occurs repeatedly in various forms throughout the code. That repetition should be eliminated, which makes it necessary to ensure the logic doesn't randomly break as that'd be difficult to debug later.
Still have to go through the code and refactor the repetitions of this, as well as remove the silly "Caching" module... but that can wait.
As a follow-up to the attempts detection fix, the UI should reflect that the item can't be obtained by players of the opposite faction. Example: Time Rift boxes display the Horde mount (wolf) on Alliance, but opening the box correctly doesn't add the attempts. That'll be quite confusing and it's best to just hide the item for Alliance players.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to the attempts detection fix, the UI should reflect that the item can't be obtained by players of the opposite faction.
Example: Time Rift boxes display the Horde mount (wolf) on Alliance, but opening the box correctly doesn't add the attempts. That'll be quite confusing and it's best to just hide the item for Alliance players.
Follow-up to #612