Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tooltip for faction specific container items #616

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Fix the tooltip for faction specific container items #616

merged 3 commits into from
Aug 20, 2023

Commits on Aug 20, 2023

  1. Tests: Added unit tests for IsItemAvailableToFactionGroup 

    This logic is mostly trivial, but it occurs repeatedly in various forms throughout the code. That repetition should be eliminated, which makes it necessary to ensure the logic doesn't randomly break as that'd be difficult to debug later.
    @rdw-software
    rdw-software committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    aa50da5 View commit details
    Browse the repository at this point in the history

  2. Core: Added a standardized function for faction checks 

    Still have to go through the code and refactor the repetitions of this, as well as remove the silly "Caching" module... but that can wait.
    @rdw-software
    rdw-software committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    2c53c5c View commit details
    Browse the repository at this point in the history

  3. UI: Fixed the tooltip for faction specific container items 

    As a follow-up to the attempts detection fix, the UI should reflect that the item can't be obtained by players of the opposite faction.

Example: Time Rift boxes display the Horde mount (wolf) on Alliance, but opening the box correctly doesn't add the attempts. That'll be quite confusing and it's best to just hide the item for Alliance players.
    @rdw-software
    rdw-software committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    2727b3e View commit details
    Browse the repository at this point in the history