Replace the LOOT_READY session lockout with a bucketed event handler #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to handle bucketed events, as we can't differentiate in the callback handler to RegisterBucketEvent. The do-end block is temporary, just to avoid an incomprehensible diff due to indentation changes.
While still somewhat questionable due to being based on a fixed timing (0.5sec), it appears to handle the sequence of LOOT_READY -> LOOT_OPENED -> LOOT_READY much better than manually managing the "session lock". That means we can delete the locking mechanism (yay) and still prevent duplicate attempts from being counted.
This was clearly an ill-conceived feature from the start (due to lack of experience on my part), only necessitated by the second LOOT_READY that Blizzard seemingly introduced after the loot window is opened. Thanks to the bucketed sequence we can completely purge it and it still works, at least as long as events trigger within the same 0.5sec burst delay. Of course, this doesn't fix attempts being lost if players are looting too fast, but if that turns out to be a problem it's trivial to adjust the delay (or even make it configurable).
rdw-software
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much cleaner, simpler, and more reliable. The timeout is still adjustable so nothing should have been lost.