Fix OnLootReady handling with 3rd party loot addons #629
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been reports of the latest loot handling change causing attempts to not be registered. After some investigation, it turns out that certain "fast loot" addons exist that basically spam-loot via LootItem API on LOOT_READY. Examples of these are AutoLootPlusPlus and ElvUI_WindTools/FastLoot Both of them cause the LOOT_OPENED event to not be triggered, which means Rarity won't trigger OnLootReady either - or at least not reliably. Since we used only LOOT_READY before, there's probably no reason to rely on LOOT_OPENED as long as the detection is working fine (and spam-opening containers doesn't fail). If this causes problems for regular users it should be rolled back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been reports of the latest loot handling change causing attempts to not be registered. After some investigation, it turns out that certain "fast loot" addons exist that basically spam-loot via LootItem API on LOOT_READY. Examples of these are AutoLootPlusPlus and ElvUI_WindTools/FastLoot
Both of them cause the LOOT_OPENED event to not be triggered, which means Rarity won't trigger OnLootReady either - or at least not reliably. Since we used only LOOT_READY before, there's probably no reason to rely on LOOT_OPENED as long as the detection is working fine (and spam-opening containers doesn't fail).
If this causes problems for regular users it should be rolled back.