Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the spell ID for Scavenging (Engineering) to the database #656

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Add the spell ID for Scavenging (Engineering) to the database #656

merged 1 commit into from
Sep 24, 2023

Conversation

astavitsky
Copy link
Contributor

Add Spell ID for the scavenging by engineers so that the scavenging of a tracked NPC would not count as an attempt.
Tested against Arachnoid Harvester.
Also tested that the scavenging spell ID is the same in different zones.
Fixes #644

@rdw-software
Copy link
Member

rdw-software commented Sep 24, 2023

Thank you! Just FYI: I'd rather not have unnecessary merge commits going back to feature branches, so I'll rebase this shortly.

If you're using GitHub desktop you could also do it yourself, by selecting this option (after removing the merge commit):

image

This fixes the LOOT_READY event handling for scavenging mechanicals.
@rdw-software rdw-software changed the title Scavenging Add spell ID for Scavenging (Engineering) Sep 24, 2023
@rdw-software rdw-software changed the title Add spell ID for Scavenging (Engineering) Add the spell ID for Scavenging (Engineering) to the database Sep 24, 2023
@rdw-software rdw-software merged commit 59e109d into WowRarity:master Sep 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scavenging Arachnoid Harvester counts as an attempt
2 participants