Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tracking for Box of Rattling Chains #661

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Implement tracking for Box of Rattling Chains #661

merged 1 commit into from
Oct 19, 2023

Conversation

cyriun
Copy link
Contributor

@cyriun cyriun commented Oct 11, 2023

im going to assume there will be a better way to do this. Probably having the table of layer ids in a different file like how the covenant ids are.

rdw-software
rdw-software reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@rdw-software rdw-software left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've a few suggestions that might be worth considering. (see review comments)

Core.lua Outdated Show resolved Hide resolved
DB/Toys/Shadowlands.lua Outdated Show resolved Hide resolved
@cyriun cyriun marked this pull request as ready for review October 15, 2023 12:01
rdw-software
rdw-software requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@rdw-software rdw-software left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug output needs to be fixed (or removed). Everything else is at your own discretion :)

Core.lua Outdated Show resolved Hide resolved
Core.lua Outdated Show resolved Hide resolved
Core.lua Outdated Show resolved Hide resolved
DB/SharedConstants.lua Outdated Show resolved Hide resolved
rdw-software
rdw-software reviewed Oct 19, 2023
View reviewed changes
Core.lua Outdated Show resolved Hide resolved
@rdw-software rdw-software linked an issue Oct 19, 2023 that may be closed by this pull request
Add tracking for Box of Rattling Chains #358
Closed
@rdw-software rdw-software changed the title draft for rattling chains item Implement tracking for Box of Rattling Chains Oct 19, 2023
@rdw-software rdw-software merged commit 8800102 into WowRarity:master Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdw-software rdw-software rdw-software approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tracking for Box of Rattling Chains
2 participants
@cyriun @rdw-software