Register the options UI with Blizzard's Addon Compartment #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
660-addon-compartment-support
branch
from
2d55838
to
e77fa8d
Compare
This is the one used by Hyacinth Macaw, which is the default tracked item.
It's unclear whether the UX could be improved by providing more options here than just "show the UI". For now, it'll just be identical in behavior to the /rarity slash command since I've no idea how people are using the new addon compartment feature.
rdw-software
force-pushed
the
660-addon-compartment-support
branch
from
e77fa8d
to
cb78d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #660. Improvements can be made later, for now this is behaving the same way as the default
/rarityslash command.