Fix an oversight in the Area POI detection #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an item doesn't require active Area POIs, which is the case for almost all items in the database, the field should simply be ignored. The code currently specifies that attempts should be disallowed in this case, which is clearly wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an item doesn't require active Area POIs, which is the case for almost all items in the database, the field should simply be ignored. The code currently specifies that attempts should be disallowed in this case, which is clearly wrong (and I missed it).
I think the reason for this is somewhat poor naming of
HasActiveAreaPOIs- it detects whether the current map has active area POIs AND whether the given list of POIs contains an entry that is currently active. This is arguably not immediately obvious, but there are other issues that need fixing also. Might need a rework the POI code to fix #721 (deferred for now).