Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 11.0.2 #731

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Update for 11.0.2 #731

merged 1 commit into from
Jul 24, 2024

Conversation

DakJaniels
Copy link
Contributor

Moved depreciated API calls to the relevant systems and updated to the new Settings System for the mini-map icon to open to the settings category directly.

@rdw-software
Copy link
Member

Thanks! I'll need to read up on the API changes before I can do a proper review, but there's one thing I did notice:

In AddonCompartment.OnClick there's some copy/pasted code that still uses InterfaceOptionsFrame_OpenToCategory. I assume this would have to be changed as well? Other than that, looks good to me at first glance. The CI failures can be fixed by running stylua, and adding any new subsystem globals in the .luacheckrc file so that luacheck doesn't complain about missing globals.

Feel free to resolve those minor issues if you like, otherwise I'll take care of the rest later.

@DakJaniels
Copy link
Contributor Author

DakJaniels commented Jul 22, 2024

I'll let ya do the stylua stuff. I've not had good experiences with it in the past lol 😆
I do know it has a GitHub action thing though you could maybe setup if that would be better?

https://github.com/marketplace/actions/stylua

Also of note, these changes were tested on the beta build 11.0.2, it seems we might only be getting 11.0.0 with the pre-patch Tuesday, I'll recheck if the changes work with that when the servers are available.

@rdw-software
Copy link
Member

The Autoformat workflow is already using that GitHub Action :)

I'll leave the review and fixups for tomorrow, when the patch is available on live servers.

@DakJaniels
Copy link
Contributor Author

Was able to test the changes on prepatch on they worked for me.

@rdw-software rdw-software changed the title update for 11.0.2 Update for 11.0.2 Jul 24, 2024
@rdw-software rdw-software merged commit 4ebfa75 into WowRarity:master Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants