Implement a more reliable TOC version check (using Blizzard's CDN) #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listing several versions doesn't make sense since only the live realms are actually supported. This was only changed because the previous TOC version check took the shortcut of comparing Rarity's interface version to that of BigWigs, which (unlike Rarity) supports PTR testing. As the TOC check now involves fetching the latest version directly from Blizzard's CDN, this hack is no longer useful and can be removed.
Instead of blindly copying BigWigs' TOC version, it's possible to query Blizzard's CDN directly. While this adds some complexity due to the oddball CSV-like format that they use, it should be more reliable. More advanced interactions like synchronization can now also be scripted in Lua, instead of having to work around various peculiarities of the different shells and terminal environments.
Since AddonLoader is no longer used, the note may be confusing/
rdw-software
force-pushed
the
cdn-version-checker
branch
from
1ed7edc
to
505c101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more involved, but allows for scripting more complex interactions (like automatically syncing versions) later on.
Improvements that could be considered in the future, but aren't yet included:
curl(CLI)