Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

feat: Export favorites and waypoints from main menu #696

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

ShadowCat117
Copy link
Contributor

@ShadowCat117 ShadowCat117 commented Nov 2, 2023

2023-11-04_10 37 34
2023-11-03_16 08 38

@ShadowCat117 ShadowCat117 requested a review from a team as a code owner November 2, 2023 14:25
magicus
magicus previously approved these changes Nov 3, 2023
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking!

@ShadowCat117
Copy link
Contributor Author

Good thinking!

I will say before this gets merged, not sure if you've seen the discussion on discord but some think this might be too intrusive as this screen always appears. I do agree but it is meant to be a constant reminder that 1.12 will be unsupported soon and it crashes a few seconds into logging in to the server anyway due to the territory changes

@magicus
Copy link
Member

magicus commented Nov 3, 2023

We said that we would try to keep Legacy crash-free even if it means removing functionality. Can we chop off the territory things that are crashing?

(And yes, I think it can be intrusive)

@ShadowCat117
Copy link
Contributor Author

Tried fixing the territory crash but something else seems to still be casing a crash, sometimes before I can even load into the server so if we want to solve that might have to be done by someone who's more familiar with legacy..

@ShadowCat117 ShadowCat117 changed the title feat: Export favorites and waypoints from update available screen feat: Export favorites and waypoints from main menu Nov 3, 2023
@Rafii2198
Copy link

I just realized two small issues that originated in my idea, so it is not anything with your implementation.

  • Saying "Artemis (1.20.2)" is not future-proof, if we update to for example 1.20.3 or 1.21 that statement will be false as well as sounds like Artemis is something else completely to Wynntils while it is just a code name.
    • I suggest changing it to something like just Wynntils Artemis or Wynntils for modern versions of Minecraft
  • Linking to whatever is the latest file on Modrinth could make the user think it is only for one specific loader, the one that happens to be uploaded the latest.

@kristofbolyai kristofbolyai merged commit 94ce153 into Wynntils:development Nov 18, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants