Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URLconfig option and code to use contour area for weights #1526

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

juehang
Copy link
Contributor

@juehang juehang commented Jan 16, 2025

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Use contours for peaklet merging weights. Main PR #1513.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • [ x ] Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@juehang juehang requested a review from dachengx January 16, 2025 21:48
@juehang juehang marked this pull request as ready for review January 17, 2025 01:01
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @juehang . I only have a small opinion.

straxen/plugins/merged_s2s/merged_s2s.py Outdated Show resolved Hide resolved
@juehang
Copy link
Contributor Author

juehang commented Jan 17, 2025

Thanks for the edit @dachengx, looks good to me 👍

@dachengx dachengx merged commit 98a295d into merged_s2s_3d Jan 17, 2025
7 checks passed
@dachengx dachengx deleted the merged_s2s_3d_probabilistic_posrec branch January 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants