Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sui token balances #96

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Fix sui token balances #96

merged 3 commits into from
Sep 1, 2023

Conversation

mat1asm
Copy link
Contributor

@mat1asm mat1asm commented Aug 30, 2023 •
edited
Loading

Closes #95
Screenshot from 2023-08-30 15-52-34

iturricf
iturricf approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@iturricf iturricf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just one question, if we pass a known token address instead of the symbol will it recognize it anyway? There's no need to implement that now if that's not the way it's working. We can add it to the backlog perhaps.

@mat1asm
Copy link
Contributor Author

mat1asm commented Aug 30, 2023

LGTM!

Just one question, if we pass a known token address instead of the symbol will it recognize it anyway? There's no need to implement that now if that's not the way it's working. We can add it to the backlog perhaps.

@iturricf made a few changes to allow for valid token addresses

@mat1asm mat1asm requested a review from iturricf August 30, 2023 18:56
iturricf
iturricf approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@iturricf iturricf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mat1asm mat1asm merged commit 3a80864 into main Sep 1, 2023
1 check passed
@mat1asm mat1asm deleted the fix/sui-balances branch September 1, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhidtu2014 abhidtu2014 abhidtu2014 approved these changes

@iturricf iturricf iturricf approved these changes

@solanoepalacio solanoepalacio Awaiting requested review from solanoepalacio

@scnale scnale Awaiting requested review from scnale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet manager not exporting SUI Balances
3 participants
@mat1asm @iturricf @abhidtu2014