Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAdESVerifier verify CertDigest by index #247

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

msetina
Copy link
Contributor

@msetina msetina commented Mar 18, 2024

Fix for #246. I found out that if I have multiple certificates in cert parameter to sign, the digest check would fail. Since it was signed with signxml, it was strange. Looking at code I found a problem. This is the solution.

@msetina
Copy link
Contributor Author

msetina commented Mar 18, 2024

Test suite fails for nonconformant-X_BE_CONN_10.xml. It has 2 X509Certificate nodes and 2 xades:Cert nodes. Previous code raised a InvalidDigest. The new code checks both Digests as OK as it compares by list index.
By removing "nonconformant-X_BE_CONN_10": InvalidDigest, from test_xades_interop_examples error_conditions, test suit will finish with OK.

@kislyuk
Copy link
Member

kislyuk commented Mar 23, 2024

Please add a PR description with the motivation for this change.

@msetina
Copy link
Contributor Author

msetina commented Mar 23, 2024

Notice that test is changed as one was an error before and now it is not as Digests match.

@kislyuk
Copy link
Member

kislyuk commented Mar 24, 2024

Thanks. I will take a look at that test case and see if this is the correct way to make it work.

@kislyuk kislyuk force-pushed the develop branch 4 times, most recently from 7e7f504 to b3de531 Compare September 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants