Missed a version check

XSoussou · Sep 19, 2023 · bb06232 · bb06232
1 parent dac2151
commit bb06232
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/main/java/com/ranull/graves/Graves.java b/src/main/java/com/ranull/graves/Graves.java
@@ -341,13 +341,6 @@ private void updateChecker() {
         }
     }
 
-    private double getVersionAsNumber(String version) throws NumberFormatException {
-        String integerPart = version.split("\\.")[0];
-        String decimalPart = version.split("-")[0].substring(integerPart.length()).replace(".", "");
-
-        return Double.parseDouble(integerPart + "." + decimalPart);
-    }
-
     private void compatibilityChecker() {
         compatibility = versionManager.hasBlockData() ? new CompatibilityBlockData() : new CompatibilityMaterialData();
 
@@ -634,4 +627,11 @@ public final int getSpigotID() {
     public final int getMetricsID() {
         return 12849;
     }
+
+    public static double getVersionAsNumber(String version) throws NumberFormatException {
+        String integerPart = version.split("\\.")[0];
+        String decimalPart = version.split("-")[0].substring(integerPart.length()).replace(".", "");
+
+        return Double.parseDouble(integerPart + "." + decimalPart);
+    }
 }
diff --git a/src/main/java/com/ranull/graves/listener/PlayerJoinListener.java b/src/main/java/com/ranull/graves/listener/PlayerJoinListener.java
@@ -25,8 +25,8 @@ public void onPlayerJoin(PlayerJoinEvent event) {
 
                 if (latestVersion != null) {
                     try {
-                        double pluginVersion = Double.parseDouble(plugin.getVersion());
-                        double pluginVersionLatest = Double.parseDouble(latestVersion);
+                        double pluginVersion = Graves.getVersionAsNumber(plugin.getVersion());
+                        double pluginVersionLatest = Graves.getVersionAsNumber(latestVersion);
 
                         if (pluginVersion < pluginVersionLatest) {
                             player.sendMessage(ChatColor.RED + "☠" + ChatColor.DARK_GRAY + " » " + ChatColor.RESET