fix: don't dump messages just because something was removed from the …

…pending replies box
Xaeroxe · Jan 2, 2023 · 5bbf7a8 · 5bbf7a8
1 parent 4155015
commit 5bbf7a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "async-io-converse"
-version = "1.0.0"
+version = "1.0.1"
 edition = "2021"
 license = "MIT OR Apache-2.0"
 description = "Can conduct a conversation over any AsyncRead or AsyncWrite type with serde compatible types"

diff --git a/src/lib.rs b/src/lib.rs
@@ -199,7 +199,6 @@ impl<R: AsyncRead + Unpin, W: AsyncWrite + Unpin, T: Serialize + DeserializeOwne
                     while let Ok(reply_data) = reply_data_receiver.try_recv() {
                         pending_reply.push(reply_data);
                     }
-                    let start_len = pending_reply.len();
                     let mut user_message = Some(i.user_message);
                     pending_reply.retain_mut(|pending_reply| {
                         if let Some(reply_sender) = pending_reply.reply_sender.as_ref() {
@@ -218,7 +217,7 @@ impl<R: AsyncRead + Unpin, W: AsyncWrite + Unpin, T: Serialize + DeserializeOwne
                         }
                         !matches
                     });
-                    if start_len == pending_reply.len() {
+                    if !i.is_reply {
                         return Poll::Ready(Some(Ok(ReceivedMessage {
                             message: Some(user_message.take().expect("infallible")),
                             conversation_id: i.conversation_id,