Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_lock_file, _unlock_file, and _fgetc_nolock #672

Open
glebm opened this issue Jul 7, 2024 · 2 comments
Open

_lock_file, _unlock_file, and _fgetc_nolock #672

glebm opened this issue Jul 7, 2024 · 2 comments

Comments

@glebm
Copy link
Contributor

glebm commented Jul 7, 2024 •
edited
Loading

Newer versions of libfmt need these 3 Windows functions, would it be possible to add them?
@glebm glebm changed the title flockfile and funlockfile flockfile, funlockfile, and getc_unlocked Jul 7, 2024
@glebm glebm changed the title flockfile, funlockfile, and getc_unlocked _lock_file, _unlock_file, and _fgetc_nolock Jul 7, 2024
@thrimbor
Copy link
Member

thrimbor commented Jul 7, 2024

Hm, that would require some rework in PDCLib, it doesn't currently expose the function without locks, and I haven't yet looked too much into the semantics either.
For the moment it's probably easier to add a check for nxdk to that ifdef and make libfmt use the fallback version of that class (looks like FMT_USE_FALLBACK_FILE will do that)

@glebm glebm mentioned this issue Jul 8, 2024
Closed
@glebm
Copy link
Contributor Author

glebm commented Jul 8, 2024

The functions are no longer required by libfmt but implementing them will improve performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glebm @thrimbor