Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Browser is not started for @After method if it's declared in different class than the test itself #322

Open
oomelianchuk opened this issue Dec 12, 2024 · 0 comments · May be fixed by #325
Open

Bug: Browser is not started for @After method if it's declared in different class than the test itself #322

oomelianchuk opened this issue Dec 12, 2024 · 0 comments · May be fixed by #325
Assignees
@oomelianchuk
Labels
bug codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop

Comments

@oomelianchuk
Copy link
Contributor

Quick Description

With the feature to start new browser for @after method if needed, we introduced this bug. Is seems that the reason is that we use method.getDeclaredClass() call to get the class to search the after methods in. Instead, we should use the actual test class that gets passed to this method.

Actual Behaviour

If @after method is declared in different class than the test itself, no webdriver is available in the method

Expected Behaviour

Test browser should be available for all @after methods, if nothing different is configured

Taks

  • Fix the issue
  • Introduce a unit test to prevent it in future
@oomelianchuk oomelianchuk added bug codeImplementationNeeded This issue requires a change in the code of Neodymium labels Dec 12, 2024
@oomelianchuk oomelianchuk self-assigned this Dec 12, 2024
oomelianchuk added a commit that referenced this issue Dec 13, 2024
@oomelianchuk
[#322] fix browser isn't started for after if test is in different class
e2f55be
oomelianchuk added a commit that referenced this issue Dec 13, 2024
@oomelianchuk
[#322] add unit tests
1d97081
@oomelianchuk oomelianchuk linked a pull request Dec 13, 2024 that will close this issue
[#322] Bug: Browser is not started for @After method if it's declared in different class than the test itself #325
Open
oomelianchuk added a commit that referenced this issue Dec 17, 2024
@oomelianchuk
[#322] fix for junit-4
1f5282b
oomelianchuk added a commit that referenced this issue Dec 18, 2024
@oomelianchuk
[#322] improve code structure
65ce070
oomelianchuk added a commit that referenced this issue Dec 18, 2024
@oomelianchuk
[#322] fix tests
5acfe02
@oomelianchuk oomelianchuk added codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop and removed codeImplementationNeeded This issue requires a change in the code of Neodymium labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oomelianchuk oomelianchuk

Labels
bug codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop
Projects
None yet
Milestone
No milestone
1 participant
@oomelianchuk