This repository has been archived by the owner on Nov 12, 2023. It is now read-only.
XRBK macro - rewrite using chumsky
#99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antikyth
added
enhancement
The xrbk_macro crate will just have the proc macros - their implementations will be in xrbk_macro_impl. This is because of limitations with proc-macro crates.
Will instead be in xrbk_macro_impl.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites XRBK macro using the
chumskyparsing library. It also extends the feature set of thederive_xrb!macro such that less messages have to be implemented manually (and so that some messages can have better APIs when written using the macro than in the previous macro syntax).Closes #98.