Decompile ST0 EntityRelicOrb #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozud
approved these changes
Sep 20, 2024
src/st/st0/37308.c
Outdated
| break; | ||
|
|
||
| case 5: | ||
| g_api.PlaySfx(0x618); |
src/st/st0/37308.c
Outdated
| break; | ||
|
|
||
| case 8: | ||
| isObtainedTextStored = self->ext.relicOrb.unk7C; |
There was a problem hiding this comment.
I kind of think this should be renamed temp or something since it's reused but it's fine either way
Xeeynamo
approved these changes
Sep 20, 2024
src/st/st0/37308.c
Outdated
| msg = g_RelicOrbTexts[0]; | ||
| } else { | ||
| ch = (ch << 8) | *msg++; | ||
| chPixSrc = g_api_func_80106A28(ch, 1); |
There was a problem hiding this comment.
Suggested change
| chPixSrc = g_api_func_80106A28(ch, 1); | |
| chPixSrc = g_api.func_80106A28(ch, 1); |
I realised src/st/entity_relic_orb.h has the same issue
src/st/st0/37308.c
Outdated
Comment on lines
45
to
47
| case 0: | ||
|
|
||
| InitializeEntity(g_InitializeData0); |
There was a problem hiding this comment.
Suggested change
| case 0: | |
| InitializeEntity(g_InitializeData0); | |
| case 0: | |
| InitializeEntity(g_InitializeData0); |
nit: let's try to avoid new empty lines when it does not make sense having them
There was a problem hiding this comment.
Good catch, this was from a removed block of code that exists in the main EntityRelicOrb and is omitted from ST0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working version of this.
Next steps will involve doing #ifdef to unify the function, but wanted to start by getting something in that matches by itself.