-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to reproduce droplet oscillation results from Adami et. al (2010) #378
Comments
Would you please also attach the particle distribution at t = 0, 0.08, 0.16, 0.26 and 0.5? |
@nilot-pal Thanks. We will take effort to have look. |
@Shuaihao-Zhang Could you take some time to have a look this issue? |
We also found this problem before, refer to this issue #288. @nilot-pal This is because the function I haven't had much time to pay attention to this issue in the past few weeks. I will try to fix this later. |
@Shuaihao-Zhang @nilot-pal Is in this case the air modeled? |
@Xiangyu-Hu , yes air is modelled, I just hid that phase in paraview. I used the 2d square droplet deformation test case as reference for the air-water-wall interaction, if that helps. |
@nilot-pal Please have check the bug fix at pull request #382 . Please try modify your case with this bug fix. |
@Xiangyu-Hu , thanks. I incorporated your changes and ran the simulation again. In terms of the COM position, the results have improved as far as being close to literature data is concerned, i.e., droplet remains stable till 0.5 sec. |
@nilot-pal the current algorithm is neither the 2006 or 2010 version. It is a simplified version. We can have a further look on it. The worst case is we simply re-implement the old algorithm. |
@Xiangyu-Hu , thanks a lot for the clarification, because I was under the impression that the algo is from the 2010 paper. |
@nilot-pal thanks for clarification. Please toke some time on other things. We will solve issue as soon as possible. |
@nilot-pal Hi, there is a bug in mulit-phase viscous acceleration and was corrected in the new pull request. Please have a try for your case. |
@Xiangyu-Hu , thanks. After incorporating changes as per #391, I got the following result: |
Still need to work on it so that the simulation be stable in long time. |
@nilot-pal I have found the problem behind the issue, it is due to the wrongly imposed transport velocity formulation. |
Great! Seems much better! |
@nilot-pal please check the new version. I think that this version, is still not perfect, but should be be sufficient for your test. |
@Xiangyu-Hu, thanks a lot for your attention to this. New result after incorporating #398 is as follows: |
@nilot-pal Great! Could you update the square_droplet case in repository with your cases test. I think that your case is more comprehensive and easier to maintain as it has observed quantitates for regression test. |
@Shuaihao-Zhang @nilot-pal We will continuously improve the surface tension model. |
Another formulation has very good stability,https://youtu.be/r7SJ7mxoPFs, until time 10. |
Hi all,
I was trying to reproduce the 2d droplet oscillation results presented in the following two papers:
However, my results don't match exactly with the literature. Attached is a screenshot of the mismatch-:
I am using an earlier version of SPHinXsys with some modifications (you can find it here: https://github.com/nilot-pal/SPHinXsys-nilo.git) to incorporate classes for finding the COM position and time steps from the 2010 paper.
Please let me know your thoughts on this!
The text was updated successfully, but these errors were encountered: