Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiangyu/check fish swiming case #369

Merged
merged 10 commits into from
Jul 16, 2023
Merged

Conversation

Xiangyu-Hu
Copy link
Owner

The problem of strange behavior for dual single time stepping seems due to the lack of numerical dissipation for momentum equation and the over correction of transport formulation for single time stepping.

@Xiangyu-Hu Xiangyu-Hu requested a review from SPHYaru July 15, 2023 23:42
@Xiangyu-Hu Xiangyu-Hu merged commit 3938509 into master Jul 16, 2023
4 checks passed
@SPHYaru
Copy link
Collaborator

SPHYaru commented Jul 16, 2023

The problem of strange behavior for dual single time stepping seems due to the lack of numerical dissipation for momentum equation and the over correction of transport formulation for single time stepping.

We added the numerical dissipation last week, and the problem still exists. So next I try to decrease the correction of the transport formulation ?

@Xiangyu-Hu Xiangyu-Hu deleted the xiangyu/check_fish_swiming_case branch July 17, 2023 16:30
@Xiangyu-Hu
Copy link
Owner Author

The problem of strange behavior for dual single time stepping seems due to the lack of numerical dissipation for momentum equation and the over correction of transport formulation for single time stepping.

We added the numerical dissipation last week, and the problem still exists. So next I try to decrease the correction of the transport formulation ?

I leave tried with single time step with smaller coefficient for transport velocity correction. It works. The current transport velocity formulation is used for dual time criteria method..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants