change getInterParticleDiffusionCoeff() of Dirichlet wall boundary #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiangyu-Hu
reviewed
Jul 29, 2023
src/shared/particle_dynamics/diffusion_reaction_dynamics/diffusion_dynamics.h
Outdated
Show resolved
Hide resolved
src/shared/particle_dynamics/diffusion_reaction_dynamics/diffusion_dynamics.hpp
Outdated
Show resolved
Hide resolved
Xiangyu-Hu
reviewed
Jul 30, 2023
|
If |
ChenxiZhaoTUM
changed the title
Xiangyu-Hu
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the getInterParticleDiffusionCoff() function of the Dirichlet wall boundary.
The diffusion coefficient of the diffusion process interacting with walls is unrelated to the wall boundary, so the old one getInterParticleDiffusionCoff(particle_i, particle_j, e_ij) tends to confuse the SPHinXsys users.
The new one getInterParticleDiffusionCoff(particle_i, particle_i, Vecd::Zero()) is more clear that the diffusion coefficient in this process (diffusion body contacted with Dirichlet boundary) has nothing to do with the contact walls.