Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without global variable #398

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Without global variable #398

merged 6 commits into from
Aug 24, 2023

Conversation

Xiangyu-Hu
Copy link
Owner

  1. revise the transport velocity formulation so that it correct all particles for multiphase flow.
  2. revised the droplet and wetting case so that the simulation can be stable to long physical time.

@Shuaihao-Zhang
Copy link
Collaborator

The result seems good for the case test_2d_square_droplet.

For the test_2d_wetting_effects case, the particle distribution is not uniform. Maybe other reasons related to the boundary condition.
image

I found two other problems, which may be not related to the current modification.
(1) The first one is that, for the test_2d_wetting_effects case, the air phase and the water phase share the same layer of particle on the interface, as shown below:
image
I found this problem when increasing the resolution. For very low resolutions, we don't have this problem. I guess the bug is from the particle generation process.

(2) The second one is that the advection time step is always the same as the acoustic time step for the two cases.
image

@Xiangyu-Hu
Copy link
Owner Author

@Shuaihao-Zhang probably the transport velocity correction is too much.

@Xiangyu-Hu Xiangyu-Hu merged commit eefb8c2 into master Aug 24, 2023
4 checks passed
@Xiangyu-Hu Xiangyu-Hu deleted the without_global_variable branch June 6, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reproduce droplet oscillation results from Adami et. al (2010)
2 participants